sarriaroman / photoviewer

PhotoViewer Cordova Plugin
MIT License
157 stars 216 forks source link

Why permissions management on android rollbacked ? #178

Closed gnarco closed 5 years ago

gnarco commented 5 years ago

Hi

I don't want to ask permission for "just" zooming on a picture.

It seems to be handle, but in the latest release : https://github.com/sarriaroman/photoviewer/commit/9aa1e90e6ca207e4b9289cbd81e1d8ffa4d11768#diff-0e5cb6b1797466c885bd3f4ed5dbe1e4 It seems to be reverted.

So I switch to 1.1.18

Any reason for this ?

Thanks

sarriaroman commented 5 years ago

Handling permissions can be done by the WebApp very easily and that is why having the logic implemented natively is not necessary or is duplicated functionality. In the case of Ionic you can check here: https://ionicframework.com/docs/native/android-permissions