Closed iharshit009 closed 4 years ago
@iharshit009 Why are you adding
..
before the import? what kind of issue are you facing? Also please change the folder namelanguageBase
totranslations
.
On adding "@" this could not recognize and disables all the imports
@sarthology @sahilit @narender2031 Made the changes
When I use @ it is not able to find the file at the location...
On Wed 22 Apr, 2020, 3:02 PM narender2031, notifications@github.com wrote:
@narender2031 requested changes on this pull request.
In src/i18n.js https://github.com/sarthology/ovuli/pull/163#discussion_r412824783:
import i18n from 'i18n-js';
-import English from '@/languageBase/en.json'; -import Hindi from '@/languageBase/hi.json'; -import Nepali from '@/languageBase/ne.json'; -import Bengali from '@/languageBase/be.json'; -import Urdu from '@/languageBase/ur.json'; -import Assamese from '@/languageBase/as.json'; -import Gujarati from '@/languageBase/gu.json'; -import Kannada from '@/languageBase/kn.json'; -import Kashmiri from '@/languageBase/ks.json'; -import Konkani from '@/languageBase/ko.json'; -import Maithili from '@/languageBase/ma.json'; -import Malayalam from '@/languageBase/ml.json'; +import English from '../translations/en.json';
why do you need ../? Are you facing an error with @/? if yes? then what is the error?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sarthology/ovuli/pull/163#pullrequestreview-398010986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQXHFHOSR2L5TASDTXQD5TRN22R5ANCNFSM4MKYYIQQ .
ok. I will check this later, for now, I will approve
@iharshit009 Why are you adding
..
before the import? what kind of issue are you facing? Also please change the folder namelanguageBase
totranslations
.