sasjs / server

Build Apps on Base SAS
https://server.sasjs.io
MIT License
20 stars 3 forks source link

Support PRINT destination natively #354

Closed allanbowe closed 1 year ago

allanbowe commented 1 year ago

Currently we direct the PRINT destination to the log, to enable output using a single return file (log)

https://github.com/sasjs/server/pull/254

This actually breaks on windows due to file locks. Instead we should implement actual print destination handling.

The print output is created here: https://github.com/sasjs/server/blob/main/api/src/controllers/internal/Session.ts#L132

path.join(session.path, 'output.lst'),

This file should be returned in the same response, using the same separator as used in the log.

This change will require a corresponding update in the sasjs/adapter repo (such change should be backwards compatible)

To dos:

allanbowe commented 1 year ago

actually this is a duplicate of (or would be handled by) #274

sasjsbot commented 1 year ago

:tada: This issue has been resolved in version 0.35.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: