Sort input file list - Githubissues

sass / sassc-ruby

Use libsass with Ruby!

MIT License

363 stars 157 forks source link

Sort input file list #178

Closed bmwiedemann closed 4 years ago

bmwiedemann commented 4 years ago

Sort input file list so that libsass.so builds in a reproducible way in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE. Package is called rubygem-sassc there.

The only other problem is that --disable-march-tune-native is not the default, so results vary depending on build worker CPU. Could also be selected if the SOURCE_DATE_EPOCH env var is set.

bolandrm commented 4 years ago

@glebm could you please review this PR?

ahorek commented 4 years ago

I think the PR is ok, see https://bugs.ruby-lang.org/issues/8709 for more context