sassoftware / clinical-standards-toolkit

The open source release of SAS Clinical Standards Toolkit is a direct port of the last production release with minor modifications to adapt to a new deployment architecture.
Apache License 2.0
27 stars 11 forks source link

Feature/definexml 2.1 #10

Closed lexjansen closed 1 year ago

lexjansen commented 1 year ago

This implements Define-XML 2.1 in openCST:

There is some documentation in:

Note: this also updates: /standards/cst-framework-1.7/control/standardlookup.sas7bdat

ContributorAgreement.txt

lexjansen commented 1 year ago

Thanks, Michael. All good comments. I will address them after I'm back from travel (CDISC Euro Interchange) this week. Thanks, Lex

lexjansen commented 1 year ago

I made all requested changes. What is your proposal for the Define-XML v2.1 IQ/OQ step? It can be accomplished by running the definexml_roundtrip_full_example.sas sample program. This program involves reading, writing and validating Define-XML v2.1. I could create a IQ/OQ markdown file in the cstdefinexml21/source/standards/doc folder.

michaelkilhullen commented 1 year ago

Just add a simple doc, similar to what we provided in the Operational Qualification doc. It just has to have steps to follow to confirm that it's working correctly based on expected outcomes. Markdown is perfectly fine.

  1. Run this program
  2. Check the log for errors
  3. Verify xx datasets created; xx has this many records; results datasets have no errors; result has a record that xxx was created successfully and the file exists; etc.
lexjansen commented 1 year ago

Perfect. I will add a Q/OQ markdown file in the cstdefinexml21/source/standards/doc folder.

lexjansen commented 1 year ago

I added a Define-XML v2.1 OQ document.

lexjansen commented 1 year ago

Excellent! So, all that is left is to create a release v1.7.6 ?

michaelkilhullen commented 1 year ago

Done!

lexjansen commented 1 year ago

Fantastic! I will show it off at PharmaSUG! Thanks for the support!!