search

sathish4fri / OssnMembers

0 stars 1 forks source link

Some thoughts ... #4

Open githubertus opened 9 years ago

githubertus commented 9 years ago

You've asked me for debugging: I can't find no real bugs so far, but what I have in mind is:

  1. Replace all instances of hardcoded strings with vars corresponding to the language file
  2. Same has to be done with urls
  3. Be careful with own styles. If possible, the style of displayed elements in OssnMembers should inherit the style of the currently chosen template. Actually, nowhere in the default template appear rounded corners and shadows like in your module. And that's why it looks like it's not really integrated into the main system.
  4. The friends part: I can reach my friends already from the profile page. So why creating another instance? I love to have a screen free from any unnecessary elements. Obsolete to my opinion.
  5. No pagination. OssnMembers is working fine with our small test communities, but what would happen in communities with hundreds of members?
sathish4fri commented 9 years ago

I agree with your point . I need to implement lot morethings with that. limited users and more functionality . but i am creating a sample it will soon added by @lianglee in ossn itslef it just a sample work ..

githubertus commented 9 years ago

Examples are always a good starting point. Yes. :) So, leave it as it is and perhaps include some more comments like .. // here would go some code for pagination // here could be a configurable switch to tell the module on which pages it will be displayed ... // ... etc ... etc ...

sathish4fri commented 9 years ago

yup . need to achieve that .