satisfactorymodding / smr-frontend

Next generation Satisfactory Modding Repository (SMR) frontend

https://satisfactorymodding.github.io/smr-frontend/main/

GNU General Public License v3.0

6 stars 24 forks source link

User-friendly display of arch compatibility, mod dependency display #81

Closed porisius closed 1 year ago

porisius commented 1 year ago

Need a code review for the follow two hints/issues.

Any implicit for two variables:

Loading svelte-check in workspace: a:\smr-frontend Getting Svelte diagnostics...

a:\smr-frontend\src\lib\components\mods\ModLatestVersions.svelte:21:24 Hint: Parameter 'targets' implicitly has an 'any' type, but a better type may be inferred from usage. (ts)

function checkTarget(targets, selectedTarget: string) { let found = false

a:\smr-frontend\src\lib\components\mods\ModLatestVersions.svelte:24:24 Hint: Parameter 'target' implicitly has an 'any' type, but a better type may be inferred from usage. (ts) if (targets.length != 0){ //support for pre-dedi targets.forEach((target) => { if (target.targetName === selectedTarget) {

====================================

Second, Datatable formatting: (see picture)

porisius commented 1 year ago

Well, this is going to be interesting... I can try to retreat to an earlier version...

$ pnpm -v 8.6.2

$ pnpm install --frozen-lockfile ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE Cannot perform a frozen installation because the version of the lockfile is incompatible with this version of pnpm

Try either:

Aligning the version of pnpm that generated the lockfile with the version that installs from it, or
Migrating the lockfile so that it is compatible with the newer version of pnpm, or
Using "pnpm install --no-frozen-lockfile". Note that in CI environments, this setting is enabled by default.

porisius commented 1 year ago

Fixed implicitly has an 'any' type,