satoren / y_ex

Yjs port for Elixir
MIT License
58 stars 2 forks source link

feat: implement observe/observe_deep #76

Open satoren opened 1 month ago

satoren commented 1 month ago

Unlike the original observe/observe_deep, it is not called in the middle of a transaction. It is called in the form of a process message after the transaction is completed.

67

Summary by CodeRabbit

Release Notes

These enhancements significantly improve the interactivity and responsiveness of the application, allowing users to track changes in real-time.

coveralls commented 1 month ago

Coverage Status

coverage: 95.422% (+0.9%) from 94.479% when pulling 18ac445856aec536a461206375e7a7f9b117f3d6 on observe into a23ce60c66bcfbe80b6a3accfd3aae92275cecbd on main.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

This pull request introduces a significant enhancement to the Yex library by adding numerous functions and modules for observing changes across various data structures, including arrays, maps, text, and XML elements. New observation functions are implemented in both Elixir and Rust, allowing developers to subscribe to changes and receive notifications through events. Additionally, new event structures are defined to facilitate this observation mechanism. The changes also include comprehensive tests to ensure the correct functionality of these new features.

Changes

File Path Change Summary
lib/nif.ex Added functions for observing changes in text, arrays, maps, and XML elements (e.g., text_observe/5, array_observe/5).
lib/protocols/awareness.ex Updated module documentation; removed example without changing functionality.
lib/shared_type/array.ex Introduced observe/2 and observe_deep/2 functions for observing arrays.
lib/shared_type/event.ex Added modules for different event types: Yex.ArrayEvent, Yex.MapEvent, Yex.TextEvent, Yex.XmlEvent, Yex.XmlTextEvent.
lib/shared_type/map.ex Introduced observe/2 and observe_deep/2 functions for observing maps.
lib/shared_type/shared_type.ex Added Yex.SharedType protocol with functions for observing shared types.
lib/shared_type/text.ex Introduced observe/2 and observe_deep/2 functions for observing text changes.
lib/shared_type/xml_element.ex Added observe/2 and observe_deep/2 functions for observing XML elements.
lib/shared_type/xml_fragment.ex Introduced observe/2 and observe_deep/2 functions for observing XML fragments.
lib/shared_type/xml_text.ex Added observe/2 and observe_deep/2 functions for observing XML text.
native/yex/src/array.rs Implemented new traits for NifArray and added array_observe and array_observe_deep functions.
native/yex/src/atoms.rs Added new atoms for event observation.
native/yex/src/event.rs Introduced structures for event handling related to shared types.
native/yex/src/lib.rs Added new module event.
native/yex/src/map.rs Enhanced NifMap with observable traits and added map_observe and map_observe_deep functions.
native/yex/src/subscription.rs Updated subscription handling with new methods and changed return types.
native/yex/src/text.rs Enhanced NifText with observable traits and added text_observe and text_observe_deep functions.
native/yex/src/xml.rs Enhanced XML-related structs with observable traits and added corresponding observe functions.
test/shared_type/array_test.exs Added tests for array observation functions.
test/shared_type/map_test.exs Added tests for map observation functions.
test/shared_type/shared_type_test.exs Introduced tests for the SharedType protocol.
test/shared_type/text_test.exs Added tests for text observation functionality.
test/shared_type/xml_element_test.exs Added tests for observing XML element changes.
test/shared_type/xml_fragment_test.exs Added tests for observing XML fragment changes.
test/shared_type/xml_text_test.exs Added tests for observing XML text changes.

Possibly related PRs

🐰 In the land of Yex, where data flows,
Observing changes, our excitement grows!
With arrays and maps, we watch them dance,
XML elements too, in a wondrous trance.
So hop along, dear friends, let's celebrate,
For in this code, we’ve opened the gate! 🎉


📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between c634c0582fa3f42c7faa71b3d7f327772cbacf4f and 18ac445856aec536a461206375e7a7f9b117f3d6.
📒 Files selected for processing (1) * `lib/shared_type/shared_type.ex` (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * lib/shared_type/shared_type.ex

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.