saurabhbakolia / SCROLLME--ECOMMERCE-WEBSITE

ScrollMe is an open-source eCommerce platform built with JavaScript, React, Styled Components, Node.js (Express), and MongoDB. It offers a modern shopping experience with a scalable backend, perfect for contributors or those learning modern web development.
https://www.scrollme.online/
MIT License
19 stars 65 forks source link

[BUG] #36 added favicon icon #82

Closed Amarjha01 closed 1 month ago

Amarjha01 commented 1 month ago

🛠️ Fixes Issue #36

closes #36

Title: [A short summary of the pull request] Added favicon icon

Description

Added a favicon icon

Screenshots (if applicable)

scrollme-removebg-preview

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrollme-ecommerce-website ❌ Failed (Inspect) Oct 6, 2024 5:17am
netlify[bot] commented 1 month ago

Deploy Preview for scrollme-ecommerce ready!

Name Link
Latest commit 6be34bf4c6d91ef5d33bd46879768cb50a1f076a
Latest deploy log https://app.netlify.com/sites/scrollme-ecommerce/deploys/67021d5c458b0f0008885285
Deploy Preview https://deploy-preview-82--scrollme-ecommerce.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

saurabhbakolia commented 1 month ago

Hey @Amarjha01 can you create a new logo, like amazon? and also use the first character of scrollme? What do you think about this ?

Amarjha01 commented 1 month ago

Hey @Amarjha01 can you create a new logo, like amazon? and also use the first character of scrollme? What do you think about this ?

This sounds good. Off course sir I'll create some awesome favicon icon like amazon using first letter in this case 'S' will be used.

Amarjha01 commented 1 month ago

scrollme

scrollme-preview

@saurabhbakolia sir is this okay now ?

vikas83pal commented 1 month ago

@saurabhbakolia I would like to work on this issue. Could you please assign me this task under the GSSOC-ext and Hacktoberfest-accepted tags? I’m excited to contribute.

i can add the logo some want like amazon sating with s with more interactive

Thanks so much!

thakuratul2 commented 1 month ago

@Amarjha01 can you provide the video link

Amarjha01 commented 1 month ago

@Amarjha01 can you provide the video link

Video link of what sir ?

thakuratul2 commented 1 month ago

@Amarjha01 favicon icon is added showing proper or not

Amarjha01 commented 1 month ago

https://github.com/user-attachments/assets/b81e66b6-3876-4394-a352-8cf2390a0777

@thakuratul2 sir avoid the that's case sensitive error. Sir I corrected all the path.

Amarjha01 commented 1 month ago

@saurabhbakolia @thakuratul2 Sir whenever I push the corrected path vercel fails to deploy. I can't view details of why Vercel was unable to deploy to solve the error.

saurabhbakolia commented 1 month ago

Hey @Amarjha01,

I think the logo made is okay, but let's give it a try @vikas83pal.

@vikas83pal can you create an attractive logo with a minimalistic design? @vikas83pal assigned!

Now that we've clarified the requirements, I’d like both of you to discuss and collaborate on creating a new logo. Please share your ideas and mockups once you’ve come to a consensus. Looking forward to seeing your creative designs!

Amarjha01 commented 1 month ago

Hey @Amarjha01,

I think the logo made is okay, but let's give it a try @vikas83pal.

@vikas83pal can you create an attractive logo with a minimalistic design? @vikas83pal assigned!

Now that we've clarified the requirements, I’d like both of you to discuss and collaborate on creating a new logo. Please share your ideas and mockups once you’ve come to a consensus. Looking forward to seeing your creative designs!

Till now I was only working on creating favicon icon but now as you mentioned logo I will look forward. @vikas83pal https://discord.com/invite/wG8CcwKN please join discord

thakuratul2 commented 1 month ago

@vikas83pal branch having conflicts

vikas83pal commented 1 month ago

@thakuratul2 in my repo it is working very fine

vikas83pal commented 1 month ago

@vikas83pal branch having conflicts

merge with bug-99

vikas83pal commented 1 month ago

@thakuratul2 please reopen the issue and add label and tags