search

sausin / laravel-ovh

Wrapper for OVH Object Storage integration with laravel
MIT License
37 stars 12 forks source link

Improved Form Post #65

Closed iksaku closed 4 years ago

iksaku commented 4 years ago

So... There's no isBefore Carbon function for Laravel 5.8... :thinking:

sausin commented 4 years ago

Thank you for all the changes to the docs!

The other PR broke some of your changes unfortunately. If you could please fix the conflicts :smiley:

EDIT:- We should maybe mention in the docs that if caching is being used, the ->getAdapter() will need to be called one more time

EDIT2:- The conflicts are now resolved. Just let me know about the other things

sausin commented 4 years ago

Also, we'd removed Carbon as a dependency sometime back. Of course, this being a laravel package the call to now() in the formsignature method won't break anything, but I was thinking it would be more consistent to not use it.

iksaku commented 4 years ago

@sausin Yeah, I remember removing dependency on Carbon from the package, and like you say, being a Laravel package, using Illuminate\Support will always provide Carbon as a dependency.

The move here could be, to either use PHP built-ins or to take advantage of Carbon being available anyways.

iksaku commented 4 years ago

For now, I will remove uses of Carbon, we can discuss this later on for another PR

sausin commented 4 years ago

@iksaku :+1: