saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
521 stars 39 forks source link

Migrated smoke test to diktat cli #1782

Closed nulls closed 10 months ago

nulls commented 10 months ago

What's done:

It closes #1781

codecov[bot] commented 10 months ago

Codecov Report

Merging #1782 (5280a97) into master (d981125) will increase coverage by 0.43%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1782      +/-   ##
============================================
+ Coverage     77.99%   78.42%   +0.43%     
  Complexity     2415     2415              
============================================
  Files           127      126       -1     
  Lines          8511     8464      -47     
  Branches       2152     2147       -5     
============================================
  Hits           6638     6638              
+ Misses          914      867      -47     
  Partials        959      959              

see 1 file with indirect coverage changes

github-actions[bot] commented 10 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 44s :stopwatch: -4s 1 389 tests ±0  1 353 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0  2 768 runs  ±0  2 732 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0 

Results for commit 5280a972. ± Comparison against base commit d981125d.

This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ disable chapters() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ fix can cause long line() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #1() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #2() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #3() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #4() … ``` ``` com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ disable chapters() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ fix can cause long line() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #1() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #2() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #3() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #4() … ```
This pull request removes 19 skipped tests and adds 19 skipped tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ disable chapters() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ fix can cause long line() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #1() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #2() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #3() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #4() … ``` ``` com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ disable chapters() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ fix can cause long line() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #1() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #2() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #3() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #4() … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 10 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   8m 57s :stopwatch: -57s 1 389 tests ±0  1 372 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0  2 768 runs  ±0  2 751 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0 

Results for commit 5280a972. ± Comparison against base commit d981125d.

This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ disable chapters() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ fix can cause long line() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #1() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #2() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #3() com.saveourtool.diktat.ruleset.smoke.DiktatSaveSmokeTest ‑ smoke test #4() … ``` ``` com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ disable chapters() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ fix can cause long line() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - FP of local variables rule() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should correctly handle tags with empty lines() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - should not fail if package is not set() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ regression - shouldn't throw exception in cases similar to #371() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #1() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #2() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #3() com.saveourtool.diktat.smoke.DiktatSaveSmokeTest ‑ smoke test #4() … ```

:recycle: This comment has been updated with latest results.