saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
519 stars 39 forks source link

Supported multiple reporters in diktat runner #1803

Closed nulls closed 8 months ago

nulls commented 8 months ago

What's done:

It closes #1802

codecov[bot] commented 8 months ago

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (0c7ed43) 78.38% compared to head (ef4fb6b) 78.33%.

Files Patch % Lines
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 18 Missing :warning:
.../saveourtool/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% 15 Missing :warning:
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 14 Missing :warning:
...om/saveourtool/diktat/ktlint/DiktatReporterImpl.kt 0.00% 7 Missing :warning:
...rtool/diktat/plugin/gradle/tasks/DiktatTaskBase.kt 76.19% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1803 +/- ## ============================================ - Coverage 78.38% 78.33% -0.05% - Complexity 2420 2421 +1 ============================================ Files 126 126 Lines 8470 8488 +18 Branches 2149 2152 +3 ============================================ + Hits 6639 6649 +10 - Misses 871 879 +8 Partials 960 960 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 8 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   7m 55s :stopwatch: + 2m 49s 1 395 tests ±0  1 359 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0  2 774 runs  ±0  2 738 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0 

Results for commit ef4fb6bb. ± Comparison against base commit 0c7ed43a.

github-actions[bot] commented 8 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   7m 26s :stopwatch: +30s 1 395 tests ±0  1 378 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0  2 774 runs  ±0  2 757 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0 

Results for commit ef4fb6bb. ± Comparison against base commit 0c7ed43a.

nulls commented 8 months ago

Hm, looks good, some refactoring, but what was the problem? Reporters did not work? What was the problem? Can you please add more info to the description of the initial issue?

Hi, updated the issue:

Gradle and maven plugins use diktat runner to run diktat. We need to support multiple reporters in diktat runner to support it in plugins https://github.com/saveourtool/diktat/issues/1733