search

savonet / ocaml-ffmpeg

OCaml bindings to the FFmpeg library.
http://www.liquidsoap.info/ocaml-ffmpeg/
GNU Lesser General Public License v2.1
48 stars 12 forks source link

Fix invalid c99 code on 0.4.1 #42

Closed luisogandob closed 4 months ago

luisogandob commented 4 years ago

It's ready to publish on 0.4.2

toots commented 4 years ago

Thanks for this PR! It seems a little too light for a full release. Have you tried the opam pin mechanism? This should work, if you're in the binding's directory with these changes applied to 0.4.1:

opam install -y .

This will pin the current repository as your fixed version for ffmpeg and installed it with your changes.

luisogandob commented 4 years ago

Hi - It"s a small PR but important. I did install using the opam pin add method but that add like 3 extra steps to install process (download code, fix, pin) and to get that conclusion it's take hours of research to users without previous experience -like me- because the first assumption is "i'm doing something wrong cause code of the example should work". As you are working on 0.5.0 i think this could be a revision 0.4.2 in the meantime. Thanks.

toots commented 4 years ago

Hi @luisogandob. I totally understand. I will keep an eye on this will consider publishing a release in the future if nothing else comes up.