savq / melange-nvim

🗡️ Warm color scheme for Neovim and beyond
MIT License
732 stars 55 forks source link

No Cursor in Noice Commandline #67

Closed quackzar closed 1 year ago

quackzar commented 1 year ago

In the Noice the cursor in the commandline is invisible, since the Cursor highlight in melanage is not set and NoiceCursor links to it. This can be fixed by either setting the Cursor or NoiceCursor to something, but is there is reason Cursor has been left unset?

Current output:

image

With NoiseCursor = {bg = a.fg, fg = a.bg}:

image
savq commented 1 year ago

the Cursor highlight in melanage is not set

Neovim sets Cursor by default. What do you get when you run :highlight Cursor ?

quackzar commented 1 year ago

Currently just Cursor xxx guifg=bg guibg=fg, which is the same as if ran with -u NONE without any color scheme at all.

savq commented 1 year ago

I don't understand what the problem is here.

If NoiceCursor links to Cursor, and Cursor is set to the default, then the cursor should appear just like it does in the command line.

If noice does something different to render the cursor, then that's a problem there, not here.

quackzar commented 1 year ago

Okay, so funnily enough if I set hi guifg=bg guibg=fg then noice's cursor appears correctly.

Doing a hi clear also wipes the noice cursor. Most other color schemes seem to define Cursor so noice just links to that. The only two solutions I really see is either providing explicit setting Cursor or providing NoiceCursor highlight for compatibility.

savq commented 1 year ago

See https://github.com/folke/noice.nvim/discussions/596