search

savvato-software / tribe-app-backend

3 stars 20 forks source link

Trib 235 #211

Closed Jayj30pro closed 2 months ago

Jayj30pro commented 6 months ago

Added delete feature to save method

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.61%. Comparing base (9d0f670) to head (8acedd2). Report is 14 commits behind head on feature/permissions-page.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/permissions-page #211 +/- ## ============================================================== + Coverage 82.59% 82.61% +0.02% Complexity 559 559 ============================================================== Files 79 79 Lines 1712 1714 +2 Branches 276 276 ============================================================== + Hits 1414 1416 +2 Misses 258 258 Partials 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haxwell commented 4 months ago

@Jayj30pro Be sure your commit messages are meaningful! The last four commits, three of which were related to a migration script, contain the same comment: They should either be in one commit with the one message, or each have descriptive messages of their own. The fourth commit, is not related to the other three, but it has the same commit message. Be careful! Also, the commit message itself is not really helpful. You wouldn't be able to look at that a year from now and understand anything about the commit.

https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/

haxwell commented 2 months ago

Hey @Jayj30pro ... all that's left here for now is to clear up the merge conflicts. For some reason, it won't let me do it in the PR. So ball's in your court..