search

sayamindu / pyhunspell

Obsolete code - see https://github.com/blatinier/pyhunspell for latest version
0 stars 0 forks source link

licensing improvements #1

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I prepared a package for Fedora and in the review some possible
improvements were noticed:

1) Please include the license text in tarball. According to the gpl howto,
you should include both the lgpl and the gpl license text in the tarball:
http://www.gnu.org/licenses/gpl-howto.html

They can be downloaded here:
http://www.gnu.org/licenses/lgpl-3.0.txt
http://www.gnu.org/licenses/gpl-3.0.txt

2) The header in hunspell.c says:
| GNU Library General Public License 
the license was renamed to "GNU Lesser General Public License" a while ago

3) The setup.py also supports a license keyword. Btw. you mixed tabstops
and spaces in the setup.py.

4) Not regarding the license:
Is it ok to rename the tarball to pyhunspell to make it obvious, that it is
not the official hunspell tarball?

I will attach a patch that takes care of all this.

Original issue reported on code.google.com by opensource@till.name on 2 Aug 2009 at 8:32

Attachments:

GoogleCodeExporter commented 9 years ago 
Ownership of the package changed to me during the summer.
Issues should be posted here now:
https://github.com/blatinier/pyhunspell/issues

I fixed this in github. Will push package in pypi soon.

Original comment by Benoit.L...@gmail.com on 16 Sep 2014 at 5:40