sayglenn / pe

0 stars 0 forks source link

Inappropriate error message for filtering by income #7

Open sayglenn opened 2 weeks ago

sayglenn commented 2 weeks ago

When using the filter command with a comparator and no income behind it, the error message indicates that it should cannot be negative or contain non-numerical character, but it should be informing users to add an income amount instead.

Screenshot 2024-11-15 at 5.14.52 PM.png

nus-pe-script commented 1 week ago

Team's Response

Thank you for your report. Upon review, we acknowledge that the error message shown is technically accurate, as it correctly indicates that the input format is invalid. However, we agree that it could be more specific and helpful by suggesting that an income amount is required after the comparator.

Given that:

  1. It is unlikely for users to only add the comparator without a number when filtering by income
  2. The current error message is not incorrect but could be refined for clarity ("could-be-better" situation)

We believe the severity should be downgraded from Medium to Low.

Once again, thank you for the bug report, we appreciate your feedback!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]