search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Install fix #237

Open wazoo opened 9 years ago

wazoo commented 9 years ago

Proposing a better fix to the install rc file creation from #114, this is dependent on an upstream fix from rbenv (https://github.com/alup/puppet-rbenv/pull/121) that adds support for multiple RC files.

Commit c816c60 includes a change to specify the rcfile in the install block, this works without upstream fix.

Commit d9adfbc includes a change that requires the upstream rbenv fix.

Without this fix I ran into an error on the first puppet run that it couldn't find bundler, this might have been a dependency issue but with this fix it works on the first puppet run.

wazoo commented 9 years ago

The builds are failing because they are using the published version of that rbenv gem, I wasn't sure how to have travis use my branch of it (without that resulting change ending up as part of this pull) so I haven't updated the tests yet.

igalic commented 9 years ago

@wazoo in .fixtures.yml

    rbenv:
      repo: "git://github.com/alup/puppet-rbenv.git"
      ref: "6628a24"

point it to your repo/branch