sbenthall / SHARKFin

Simulating Heterogeneous Agents with Finance
7 stars 5 forks source link

Cloud Automation Support #247

Open wjt5121 opened 1 year ago

wjt5121 commented 1 year ago

1 . Provides the automated tools to create simulation configurations and execute simulations against a Slurm cluster.

  1. Additional Code for Azure Service Bus enabled Market Class
gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 15 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucas.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-a79362cc17244cb4bf575fa084b7197aL37) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucasShark.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-d483807fb263a209e157afc7d9c15b26L38) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucasSharkStats.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-53e0b5508f2223d42549162be6197f46L218) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/AMMPS_ONLY/slurmRunnerAMMPS.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-7e115b9c534ef0e480e49f5b2312a009L37) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-17c745e3f95688e324769e2cb82a50d2L161) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-17c745e3f95688e324769e2cb82a50d2L514) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-17c745e3f95688e324769e2cb82a50d2L561) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-17c745e3f95688e324769e2cb82a50d2L573) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-17c745e3f95688e324769e2cb82a50d2L1906) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-17c745e3f95688e324769e2cb82a50d2L1930) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/automation/slurmRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-076ae7f358b3c2f2146b137eba34feb0L219) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | fb0755d052dc22874770d8da215ec8a71db6dcd2 | cloud/node_config/01-os-config-alma-linux.sh | [View secret](https://github.com/sbenthall/SHARKFin/commit/fb0755d052dc22874770d8da215ec8a71db6dcd2#diff-a582631028b82be2e3cb05e5b185b577L41) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | 3c80ca70398307273d37e3acffb017ffacc8c2eb | cloud/automation/simRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/3c80ca70398307273d37e3acffb017ffacc8c2eb#diff-17c745e3f95688e324769e2cb82a50d2R161) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Microsoft Azure Storage Account Key | 3c80ca70398307273d37e3acffb017ffacc8c2eb | cloud/automation/slurmRunner.py | [View secret](https://github.com/sbenthall/SHARKFin/commit/3c80ca70398307273d37e3acffb017ffacc8c2eb#diff-076ae7f358b3c2f2146b137eba34feb0R219) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | 3c80ca70398307273d37e3acffb017ffacc8c2eb | cloud/node_config/01-os-config-alma-linux.sh | [View secret](https://github.com/sbenthall/SHARKFin/commit/3c80ca70398307273d37e3acffb017ffacc8c2eb#diff-a582631028b82be2e3cb05e5b185b577R41) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/microsoft_azure_storage_account_key#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

sbenthall commented 1 year ago

Hello @wjt5121 Thanks for this. But GitGuardian is warning that there are secret keys in this PR, which is open to the public Internet.

Would it be possible to separate these out into a config file without the secrets in it, and then send us a config file with the real secrets in it?

You may also want to change the 'secrets' that have now been made public...

wjt5121 commented 1 year ago

Oh yeah... duh... I totally forgot I had connection strings all over those run books. I've rotated the keys and will get it cleaned up and resubmit. Thanks!!

wjt5121 commented 1 year ago

Removed Secrets and updated runbook.