search

sbgisen / .github

GitHub meta repository for sbgisen.
0 stars 4 forks source link

lintで落ちている理由がログから判別出来ない #16

Closed MikhailBertrand closed 2 years ago

MikhailBertrand commented 2 years ago

概要

xmllintで失敗しているときに-fail-on-errorオプションの影響なのか

reviewdog: input data has violations

でxmllintにエラーがあると原因を表示せずに変更を無視してしまう？

fail-on-error（https://github.com/reviewdog/reviewdog/issues/848#issuecomment-757434220 ）

MikhailBertrand commented 2 years ago

ログ抜粋（https://github.com/sbgisen/cube/pull/718/checks?check_run_id=3878504277 ）

Run $GITHUB_ACTION_PATH/script.sh
  $GITHUB_ACTION_PATH/script.sh
  shell: /bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    INPUT_GITHUB_TOKEN: ***
    INPUT_TOOL_NAME: xmllint
    INPUT_LEVEL: warning
    INPUT_FILTER_MODE: file
    INPUT_FAIL_ON_ERROR: true
    INPUT_REVIEWDOG_FLAGS: 
    INPUT_WORKDIR: 
Saved working directory and index state WIP on (no branch): 81fe279 Merge e0936f48a40d4dbf8505ca349ee3d182fd429892 into 8d81f8ec92dfa8b42ff93604b3d39ab05cdd9c40
cube_expression/package.xml:1:-<?xml version="1.0" encoding="UTF-8"?>
cube_expression/package.xml:2:-<package format="2">
cube_expression/package.xml:3:-  <name>cube_expression</name>
cube_expression/package.xml:4:-  <version>1.0.0</version>
cube_expression/package.xml:5:-  <description>The cube_expression package</description>
cube_expression/package.xml:6:-  <maintainer email="SBGRP-git@g.softbank.co.jp">SoftBank corp.</maintainer>
cube_expression/package.xml:7:-  <license>Apache 2.0</license>
cube_expression/package.xml:8:-  <url type="repository">https://github.com/sbgisen/cube</url>
cube_expression/package.xml:9:-  <url type="bugtracker">https://github.com/sbgisen/cube/issues</url>
cube_expression/package.xml:10:-  <buildtool_depend>catkin</buildtool_depend>
cube_expression/package.xml:11:-  <build_depend>roscpp</build_depend>
cube_expression/package.xml:12:-  <build_depend>roslib</build_depend>
cube_expression/package.xml:13:-  <build_depend>std_msgs</build_depend>
cube_expression/package.xml:14:-  <build_depend>cv_bridge</build_depend>
cube_expression/package.xml:15:-  <build_depend>libx11</build_depend>
cube_expression/package.xml:16:-  <build_depend>libxrandr</build_depend>
cube_expression/package.xml:17:-  <build_export_depend>std_msgs</build_export_depend>
cube_expression/package.xml:18:-  <exec_depend>roscpp</exec_depend>
cube_expression/package.xml:19:-  <exec_depend>std_msgs</exec_depend>
cube_expression/package.xml:20:-  <test_depend>rostest</test_depend>
cube_expression/package.xml:21:-  <test_depend>roslaunch</test_depend>
cube_expression/package.xml:22:-  <export>
cube_expression/package.xml:23:-  <export/>
cube_expression/package.xml:24:-</package>
reviewdog: input data has violations
HEAD detached at pull/718/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   cube_expression/package.xml

no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (90fa7ef1f25e680bef68270462b3f5bc98c52781)
Error: Process completed with exit code 1.
Tacha-S commented 2 years ago

pythonにおいてlinterの時点でformatに関するエラーを吐いてしまうので先にformatterかけてましたが、 xmlにおいてはlinterが先に無いとschemaに依らないxmlの構文にミスがあった際に正常にエラーを吐いてくれないみたいですね。 デバッグありがとうございます。