sbooth / Max

An audio converter and CD ripper
https://sbooth.org/Max/
GNU General Public License v2.0
276 stars 60 forks source link

Allow providing MusicBrainz link for metadata #46

Open jsumners opened 1 year ago

jsumners commented 1 year ago

I realize it's a longshot that you'll even read this @sbooth, but:

I have a newly released CD that Max is unable to find in the MusicBrainz database. However, the release is there and populated -- https://musicbrainz.org/release/5a76e9f4-9f95-4104-a7c0-0b3dfc6e82c6. It would be helpful if we could provide the XML link for a release such that Max will populate all of the metadata.

Thank you for the work you've done on this tool. I dread the day it stops working due to some macOS or hardware update. It's a far better ripper than iTunes/Music/Whatever-Apple-Calls-Their-Tool-Today.

sbooth commented 1 year ago

Does Max calculate the MusicBrainz ID correctly? The easiest way to see what Max thinks the ID is is by inspecting the disc's .cdinfo file in ~/Library/Application Support/Max/ and looking for the musicbrainzAlbumId key.

jsumners commented 1 year ago

The id that Max computes seems to be wyhCwPfeq0KcRIqD_G3kpLO.UMY-.

cdinfo ```xml MCN 0602448191427 discID wyhCwPfeq0KcRIqD_G3kpLO.UMY- tracks ISRC GBCQT2200112 channels 2 copyPermitted dataTrack firstSector 0 lastSector 15520 number 1 preEmphasis ISRC GBCQT2200112 channels 2 copyPermitted dataTrack firstSector 15521 lastSector 40902 number 2 preEmphasis ISRC GBCQT2200114 channels 2 copyPermitted dataTrack firstSector 40903 lastSector 55767 number 3 preEmphasis ISRC GBCQT2200115 channels 2 copyPermitted dataTrack firstSector 55768 lastSector 74026 number 4 preEmphasis ISRC GBCQT2200115 channels 2 copyPermitted dataTrack firstSector 74027 lastSector 94908 number 5 preEmphasis ISRC GBCQT2200117 channels 2 copyPermitted dataTrack firstSector 94909 lastSector 115151 number 6 preEmphasis ISRC GBCQT2200117 channels 2 copyPermitted dataTrack firstSector 115152 lastSector 134466 number 7 preEmphasis ISRC GBCQT2200119 channels 2 copyPermitted dataTrack firstSector 134467 lastSector 157776 number 8 preEmphasis ISRC GBCQT2200120 channels 2 copyPermitted dataTrack firstSector 157777 lastSector 177669 number 9 preEmphasis ISRC GBCQT2200121 channels 2 copyPermitted dataTrack firstSector 177670 lastSector 191971 number 10 preEmphasis ISRC GBCQT2200122 channels 2 copyPermitted dataTrack firstSector 191972 lastSector 208872 number 11 preEmphasis ```
jsumners commented 1 year ago

I just had the same thing happen with this release -- https://www.discogs.com/release/26141603-Orbital-Optical-Delusion (https://musicbrainz.org/release/3e53e0a1-1390-4f8b-8a86-627fcf50d485).

Basically, no one has submitted disc ids to MusicBrainz for these CDs. For this Orbital release, I used the MusicBrainz Picard tool to submit a disc id. I then clicked the MusicBrainz query button in Max and it found the metadata.

I'm not well versed with the MusicBrainz system (genuinely shocked I even had a login for it). Would it be possible for Max to submit a new disc id if we are able to point Max to the right release?

sbooth commented 1 year ago

MusicBrainz appears to return information on the correct disc when querying https://musicbrainz.org/ws/2/discid/wyhCwPfeq0KcRIqD_G3kpLO.UMY-

<metadata xmlns="http://musicbrainz.org/ns/mmd-2.0#">
<disc id="wyhCwPfeq0KcRIqD_G3kpLO.UMY-">
<sectors>209023</sectors>
<offset-list count="11">
<offset position="1">150</offset>
<offset position="2">15671</offset>
<offset position="3">41053</offset>
<offset position="4">55918</offset>
<offset position="5">74177</offset>
<offset position="6">95059</offset>
<offset position="7">115302</offset>
<offset position="8">134617</offset>
<offset position="9">157927</offset>
<offset position="10">177820</offset>
<offset position="11">192122</offset>
</offset-list>
<release-list count="1">
<release id="39ea2697-bb19-48f7-a67c-9f8f3833d0e4">
<title>Moving on Skiffle</title>
<status id="4e304316-386d-3409-af2e-78857eec5cfe">Official</status>
<quality>normal</quality>
<packaging id="e724a489-a7e8-30a1-a17c-30dfd6831202">Gatefold Cover</packaging>
<text-representation>
<language>eng</language>
<script>Latn</script>
</text-representation>
<date>2023-03-10</date>
<country>XE</country>
<release-event-list count="1">
<release-event>
<date>2023-03-10</date>
<area id="89a675c2-3e37-3518-b83c-418bad59a85a">
<name>Europe</name>
<sort-name>Europe</sort-name>
<iso-3166-1-code-list>
<iso-3166-1-code>XE</iso-3166-1-code>
</iso-3166-1-code-list>
</area>
</release-event>
</release-event-list>
<barcode>602448191410</barcode>
<cover-art-archive>
<artwork>true</artwork>
<count>8</count>
<front>true</front>
<back>true</back>
</cover-art-archive>
<medium-list count="2">
<medium>
<position>1</position>
<format id="9712d52a-4509-3d4b-a1a2-67c88c643e31">CD</format>
<disc-list count="1">
<disc id="wyhCwPfeq0KcRIqD_G3kpLO.UMY-">
<sectors>209023</sectors>
<offset-list count="11">
<offset position="1">150</offset>
<offset position="2">15671</offset>
<offset position="3">41053</offset>
<offset position="4">55918</offset>
<offset position="5">74177</offset>
<offset position="6">95059</offset>
<offset position="7">115302</offset>
<offset position="8">134617</offset>
<offset position="9">157927</offset>
<offset position="10">177820</offset>
<offset position="11">192122</offset>
</offset-list>
</disc>
</disc-list>
<track-list count="11"/>
</medium>
<medium>
<position>2</position>
<format id="9712d52a-4509-3d4b-a1a2-67c88c643e31">CD</format>
<disc-list count="1">
<disc id="o__07prhD7C7tvMfDUZN9SGFOGQ-">
<sectors>214916</sectors>
<offset-list count="12">
<offset position="1">150</offset>
<offset position="2">18976</offset>
<offset position="3">35399</offset>
<offset position="4">50084</offset>
<offset position="5">66828</offset>
<offset position="6">82233</offset>
<offset position="7">96763</offset>
<offset position="8">110581</offset>
<offset position="9">123919</offset>
<offset position="10">139381</offset>
<offset position="11">160224</offset>
<offset position="12">174236</offset>
</offset-list>
</disc>
</disc-list>
<track-list count="12"/>
</medium>
</medium-list>
</release>
</release-list>
</disc>
</metadata>

As you noticed, there isn't a disc ID for the release in MusicBrainz which is why Max can' find any results. It's certainly possible to submit disc IDs although I can't remember now why that functionality wasn't implemented in the first place. I will have to look into how much work that would entail.

jsumners commented 1 year ago

I will have to look into how much work that would entail.

👍

jsumners commented 1 year ago

For what it's worth, someone added the disc ids for the Van Morrison release on 2022-03-19 and Max now correctly finds it: