sbpp / sourcebans-pp

Admin, ban, and comms management system for the Source engine
https://sbpp.github.io/
Creative Commons Attribution Share Alike 4.0 International
338 stars 173 forks source link

BanIdentity native that allows the plugin to fill out missing data like names, and IPs #728

Open eyal282 opened 3 years ago

eyal282 commented 3 years ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

A native to be created that allows the banning plugin to fill out data that is missing like IP, admin name, player name, etc...

Describe alternatives you've considered

Making a pull request here with a native.

Additional context

eyal282 commented 3 years ago

Updating that this is still necessary.

Ban Disconnected plugins forces my admins to manually input names, and IP Addresses are still lost.

Adrianilloo commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

eyal282 commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

ashort96 commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

Were you not going to submit a PR?

eyal282 commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

Were you not going to submit a PR?

Absolutely not wasting my time with having PRs declined for special syntax rules.

CrazyHackGUT commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

Were you not going to submit a PR?

Absolutely not wasting my time with having PRs declined for special syntax rules.

This rules written for simplify support plugin for everyone interested includes the maintainers. Try commit in any big open-source repository (like dotnet or linux) without following their own rules, man, you will be very surprised, i guess.

eyal282 commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

Were you not going to submit a PR?

Absolutely not wasting my time with having PRs declined for special syntax rules.

This rules written for simplify support plugin for everyone interested includes the maintainers. Try commit in any big open-source repository (like dotnet or linux) without following their own rules, man, you will be very surprised, i guess.

My stance still stands, if someone needs this enough, he can go PR himself, or ask SBPP directly, which they won't add.

Hackmastr commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

Were you not going to submit a PR?

Absolutely not wasting my time with having PRs declined for special syntax rules.

This rules written for simplify support plugin for everyone interested includes the maintainers. Try commit in any big open-source repository (like dotnet or linux) without following their own rules, man, you will be very surprised, i guess.

My stance still stands, if someone needs this enough, he can go PR himself, or ask SBPP directly, which they won't add.

As CrazyHackGUT already stated it's standard procedure to follow code rules in any repository.

You seem to have a misconception, you are not entitled to anything. Its FOSS code, if you want to add features go ahead. People maintaining this repository have other things to do then just add whatever you wish.

eyal282 commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

They don't care. I have a powerful SQLiteBans plugin, maybe it is worth adding MySQL support to it.

Were you not going to submit a PR?

Absolutely not wasting my time with having PRs declined for special syntax rules.

This rules written for simplify support plugin for everyone interested includes the maintainers. Try commit in any big open-source repository (like dotnet or linux) without following their own rules, man, you will be very surprised, i guess.

My stance still stands, if someone needs this enough, he can go PR himself, or ask SBPP directly, which they won't add.

As CrazyHackGUT already stated it's standard procedure to follow code rules in any repository.

You seem to have a misconception, you are not entitled to anything. Its FOSS code, if you want to add features go ahead. People maintaining this repository have other things to do then just add whatever you wish.

I don't program in CS:GO anymore, it's completely up to the maintainers and external programmers who need it. But some people that come here are server owners who want Ban Disconnected to work properly.

CrazyHackGUT commented 3 years ago

As CrazyHackGUT already stated it's standard procedure to follow code rules in any repository. You seem to have a misconception, you are not entitled to anything. Its FOSS code, if you want to add features go ahead. People maintaining this repository have other things to do then just add whatever you wish.

I don't program in CS:GO anymore, it's completely up to the maintainers and external programmers who need it. But some people that come here are server owners who want Ban Disconnected to work properly.

Lol. SourceMod - isn't only CS:GO. And SourceBans too.

eyal282 commented 3 years ago

As CrazyHackGUT already stated it's standard procedure to follow code rules in any repository. You seem to have a misconception, you are not entitled to anything. Its FOSS code, if you want to add features go ahead. People maintaining this repository have other things to do then just add whatever you wish.

I don't program in CS:GO anymore, it's completely up to the maintainers and external programmers who need it. But some people that come here are server owners who want Ban Disconnected to work properly.

Lol. SourceMod - isn't only CS:GO. And SourceBans too.

I left Sourcemod. I only maintain plugins.

Adrianilloo commented 3 years ago

I second this feature, as it would be convenient for a custom bans exporter plugin, needed for RCON hacking bans.

Unrelated to the latest blaming.

For anyone interested -possibly related to this issue, per my needs- I've finally created an automatic SRCDS native IP bans SQL synchronizer plugin. Should work perfectly :).

Enjoy!