search

sbt / sbt-license-report

Report on licenses used in an sbt project.
89 stars 32 forks source link

Maven placeholder is not replaced. #92

Open arw357 opened 10 months ago

arw357 commented 10 months ago

Having a pom such as this
https://repo1.maven.org/maven2/org/keycloak/keycloak-adapter-core/23.0.0/keycloak-adapter-core-23.0.0.pom 

<groupId>org.keycloak</groupId>
     <artifactId>${keycloak.crypto.artifactId}</artifactId>
</dependency>

Will lead to :

(updateLicenses) sbt.librarymanagement.ResolveException: unresolved dependency: org.keycloak#${keycloak.crypto.artifactId};working@company: java.net.URISyntaxException: Illegal character in path at index 64: https://nexus.io/repository/company-central/org/keycloak/${keycloak.crypto.artifactId}/working@company/${keycloak.crypto.artifactId}-working@company.pom
mdedetrich commented 10 months ago

This may be related to https://github.com/sbt/sbt-license-report/issues/87, tl;dr is that currently sbt-license-report does dependency resolution manually via Ivy which causes problems similar to this. Ideally we would re-use the standard DependencyResolution mechanism (which defaults to coursier) but as you can see from the previously mentioned issue this is currently blocked.

raboof commented 2 days ago

@arw357 do you see this issue with version 1.6.1 as well? it looks superficially similar to the issue we're seeing in https://github.com/apache/pekko-connectors/pull/879