search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.6k stars 442 forks source link

Fix multi-platform builds with multiple aliases. #1651

Open zarthross opened 10 hours ago

zarthross commented 10 hours ago

Multi-platform builds append a -t argument for each alias to the dockerBuildOptions, but the publishTask function was ALWAYS iterating over the aliases even if it was a multi-platform build.

https://github.com/sbt/sbt-native-packager/blob/7c6885910c382784bcd2cd9fc63c2794a9dbd0a2/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala#L157-L159

The consequence was attempts to buildx and push the tags multiple times. In some environments this leads to build failures because you can't push the same tag twice.

This change simply does not iterate over the aliases for multiplatform builds.

Note: using dockerUpdateLatest := true counts as having multiple aliases, which is how I encountered this bug.

lightbend-cla-validator commented 10 hours ago

Hi @zarthross,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Akka Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

http://www.lightbend.com/contribute/cla

zarthross commented 9 hours ago

The CLA signer process is broken... I cannot sign it... not sure what ya'll want to do about it.

zarthross commented 9 hours ago

This is basically a 1 line fix, i do not care about the CLA, i do not care about copy right to the code, just wanted others to have the fix.....

dwickern commented 7 hours ago

The CLA bot has an insecure http: URL... This link should work: https://www.lightbend.com/contribute/cla