sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Improve unknown message type handling #277

Closed havocp closed 9 years ago

havocp commented 9 years ago

An important point about this setup is that unknown events and requests are "allowed" (it's part of the protocol that you're supposed to ignore them), while unknown responses are not (if the responses to a request change, that isn't backward compatible). We still convert unknown responses to ErrorResponse, and ignore UnknownMessage.

eed3si9n commented 9 years ago

LGTM

jsuereth commented 9 years ago

LGTM

havocp commented 9 years ago

Two green, going with it