List creation requirements

scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders

https://op-retropgf3-discovery-voting.vercel.app

MIT License

14 stars 14 forks source link

List creation requirements #161

Closed ZakGriffith closed 9 months ago

ZakGriffith commented 11 months ago

When sharing a list, currently only the name is required. We should clean up the front end behavior of this modal and also make the description required.

Make description required
Make the front end check to see if they have the required fields filled out and give them an error when the try to share it if not. This way they won't just get a blank default error.

electrone901 commented 10 months ago

I can help if need it

electrone901 commented 10 months ago

Screenshot 2023-11-08 at 8 42 05 PM

electrone901 commented 10 months ago

@ZakGriffith how do you envision this? What are your thoughts about having front-end validation for every field like the image below? Do we have any number of characters required for each field? Screenshot 2023-11-08 at 8 54 58 PM

ZakGriffith commented 10 months ago

Yes, we have limits on the list items. I believe it is 75 chars for the title, and 1000 for the description and impact as seen in this PR https://github.com/scaffold-eth/OP-RetroPGF3-Discovery-Voting/pull/122

I think we should require the name and description and leave the impact and tags optional. (Using the front end)

electrone901 commented 10 months ago

Great, working on this