search

scala-steward-org / scala-steward

:robot: A bot that helps you keep your projects up-to-date
Apache License 2.0
1.15k stars 502 forks source link

Linking scalatest scalafix rules to scalatestplus dependency too #1532

Open kiranbayram opened 4 years ago

kiranbayram commented 4 years ago

Hello there,

Should we link scalatest scalafix rules to scalatestplus dependency too, so that for example when scalatestplus is updated to 5.1.x, the scalatest scalafix rule for 3.1.x is also applied. WDYT?

Cheers 🍻

kiranbayram commented 4 years ago

Hello @fthomas , do you have any comments on this ?

fthomas commented 4 years ago

I guess your reason for doing that is that scalatestplus-play pulls scalatest in as transitive dependency and builds are more likely to just depend on scalatestplus-play instead of both dependencies? It seems to raise the more general question if Scala Steward should run Scalafix migrations on bumps of transitive dependencies.

kiranbayram commented 4 years ago

Yes, you summed it up pretty well 👍

fthomas commented 4 years ago

Ok. My current thinking is that it would be okay to run migrations for transitive dependency bumps (however Scala Steward figures out that it should run a migration in these cases) but we should not link downstream dependencies to Scalafix migrations of upstream dependencies here in the scalafix-migrations.conf file because we can't enumerate every single downstream dependency.