search

scalacenter / scalajs-bundler

https://scalacenter.github.io/scalajs-bundler
Other
237 stars 101 forks source link

Upgrade to Scala.js 1.3.0 #374

Closed sjrd closed 4 years ago

sjrd commented 4 years ago

This commit contains the minimum amount of changes for scalajs-bundler to work with Scala.js 1.3.0. However, it still only works when module splitting is not actually used. To be precise, it still relies on the legacy keys fastOptJS and fullOptJS, and therefore on the fact that linking only produces one module.

Integrating with module splitting is left for future work.

sjrd commented 4 years ago

There a few tests that fail on the Windows CI with errors like

java.io.IOException: Could not create directory C:\Users\appveyor\AppData\Local\Temp\1\sbt_cd2121ed\play\client\target\scala-2.13\client-fastopt: java.nio.file.AccessDeniedException: C:\Users\appveyor\AppData\Local\Temp\1\sbt_cd2121ed\play\client\target\scala-2.13\client-fastopt

although they work fine locally on Windows. I'm not sure what's happening :s

sjrd commented 4 years ago

@julienrf Could you have a look at the second commit, which works around the AppVeyor issues? Is that OK with you?

julienrf commented 4 years ago

Ouch, this is not super nice, but I must confess that I don’t have a better solution… So, this looks good to me.

SethTisue commented 4 years ago

will a release be along shortly? I see https://github.com/scalacenter/scastie/issues/481 is blocked (cc @OlegYch @Sciss)

sjrd commented 4 years ago

I'll make a release tomorrow.