search

scaleway / docker-machine-driver-scaleway

:whale: Scaleway driver for Docker Machine
MIT License
248 stars 34 forks source link

Allow the bootscript to be specified using it's unique id. #85

Closed twk3 closed 6 years ago

twk3 commented 6 years ago

Related to some of the issues we are seeing in: https://github.com/scaleway/docker-machine-driver-scaleway/issues/84

Right now the 'docker' bootscript, is still the default, though that does not appear to exist in scaleway anymore. I've left it as the default until we hear for sure it's not coming back.

With this PR, you can pass the name of a bootscript to use it, and you can also pass --scaleway-bootscript="" to clear the default, and let the scaleway server use it's default. (The default kernels are supposed to work with docker and docker-machine now)

I have tested that using this with 'docker' image is working.

A separate issue right now is that the default image, 'ubuntu-xenial', also doesn't exist, so you need to manually specify an image.

twk3 commented 6 years ago

Binary available here: https://github.com/twk3/docker-machine-driver-scaleway/releases/tag/v1.4-dev1

remyleone commented 6 years ago

@halmartin @superseed Could you review it?

halmartin commented 6 years ago

Presumably if the user specifies a bootscript id which doesn't exist, creating the server will fail. A check for the bootscript would be nice, but I see we're not exactly checking for other things (e.g. volume id) before attempting to create the server, so LGTM.

karser commented 6 years ago

Thanks, --scaleway-bootscript="" works fine. Not sure if it's related to this PR, but I wasn't able to remove the non-existing local references that were created with v1.3. I described the error in the issue above.