search

scality / Arsenal

Common utilities for the open-source Scality S3 project components
Apache License 2.0
15 stars 19 forks source link

Improvement/arsn 362 imp deny #2164

Closed KazToozs closed 1 year ago

KazToozs commented 1 year ago

Opened after closed PR here

Adds ImplicitDeny logic to policy checks, where an ImplicitDeny will be sent back in case no policy validates an action, but does not explicitly Deny it either, allowing for bucket policies and other authorization mechanisms to grant permission.

Part of the bucket policy redo epic: https://scality.atlassian.net/jira/software/c/projects/OS/boards/214?modal=detail&selectedIssue=S3C-7756

Green build in Vault and CS: https://github.com/scality/Vault/actions/runs/6151692989/job/16692302075?pr=2135 https://github.com/scality/cloudserver/actions/runs/6157396066/job/16708032893?pr=5322

bert-e commented 1 year ago

Hello kaztoozs,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 1 year ago

Branches have diverged

This pull request's source branch improvement/ARSN-362-impDeny has diverged from development/8.1 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the following solutions:

Note: If you choose to rebase, you may have to ask me to rebuild integration branches using the reset command.

bert-e commented 1 year ago

Incorrect fix version

The Fix Version/s in issue ARSN-362 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of ARSN-362, or the target branch of this pull request.

KazToozs commented 1 year ago

Must make variables consistent between clients https://github.com/scality/Arsenal/pull/2162#pullrequestreview-1615732187

bert-e commented 1 year ago

Incorrect fix version

The Fix Version/s in issue ARSN-362 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of ARSN-362, or the target branch of this pull request.

KazToozs commented 1 year ago

Must make variables consistent between clients https://github.com/scality/Arsenal/pull/2162#pullrequestreview-1615732187

done

KazToozs commented 1 year ago

ping

bert-e commented 1 year ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests
bert-e commented 1 year ago

Waiting for approval

The following approvals are needed before I can proceed with the merge: