search

scality / Arsenal

Common utilities for the open-source Scality S3 project components
Apache License 2.0
15 stars 19 forks source link

ARSN-365:Id added on policy schema and validator #2165

Closed benzekrimaha closed 1 year ago

benzekrimaha commented 1 year ago

Description

Motivation and context

This PR adds support of the Id definition on resource policy document Green build in CS: https://github.com/scality/cloudserver/actions/runs/6164727071/job/16731455987?pr=5333 CS PR link : https://github.com/scality/cloudserver/pull/5333

Checklist

Add tests to cover the changes

existing tests modified to cover all changes

bert-e commented 1 year ago

Hello benzekrimaha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 1 year ago

Incorrect fix version

The Fix Version/s in issue ARSN-365 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of ARSN-365, or the target branch of this pull request.

benzekrimaha commented 1 year ago

ping

bert-e commented 1 year ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests
bert-e commented 1 year ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

benzekrimaha commented 1 year ago

@bert-e create_pull_requests

bert-e commented 1 year ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

Follow integration pull requests if you would like to be notified of build statuses by email.

The following options are set: create_pull_requests

bert-e commented 1 year ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

The following options are set: create_pull_requests

benzekrimaha commented 1 year ago

/approve

bert-e commented 1 year ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve, create_pull_requests

bert-e commented 1 year ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue ARSN-365.

Goodbye benzekrimaha.