scarv / xcrypto

XCrypto: a cryptographic ISE for RISC-V
MIT License
91 stars 10 forks source link

Spec+Implementation: residual inconsistencies #46

Closed danpage closed 5 years ago

danpage commented 5 years ago

From a proof-read, two issues popped up:

  1. The mnemonic vs. condition of xc.cmov.{t,f} are flipped; we agreed to flip them back.

    • [x] specification
    • [x] implementation
  2. Vs. xc.macc.2, which uses crd2 and crd1 as the MSBs and LSBs mirroring the assembly language syntax, all the shifts, i.e., xc.msll, xc.msll.i, xc.msrl, and xc.msrl.i, do the opposite; we agreed to flip the shifts to match.

    • [x] specification
    • [x] implementation