Open rxseger opened 8 years ago
Hi Robert,
It's a great pleasure to see that this project works for you. But I am currently some kind of busy, and there is not enough time for me to submit a pull request for homebrew-core repo or do other kind of maintainance work.
I have added you as a collaborator of this project. You can push your changes directly into this repo, and do what you need to make this project more useful for other people.
Thanks.
Wang Kang
Thanks scateu! I'll see what I can do.
@scateu trying to push changes from my fork to here but I'm getting access denied, can you check:
kalibrate-hackrf $ git remote -v | grep origin
origin git@github.com:scateu/kalibrate-hackrf (push)
origin git@github.com:scateu/kalibrate-hackrf (fetch)
kalibrate-hackrf $ git push -u origin master
ERROR: Permission to scateu/kalibrate-hackrf.git denied to rxseger.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Collaborators Push access to the repository
@rxseger
Robert X. Seger
Awaiting rxseger's response
It seems that you have to confirm my invitation at some where.
Got it, cheers! Pushed my changes
Issues to resolve before publishing 1.0:
Instead of https://github.com/scateu/kalibrate-hackrf/blob/master/INSTALL.homebrew manual instruction steps, why not submit a formula to homebrew-core so installation is simple as
brew install kalibrate-hackrf
?I started one here: https://github.com/rxseger/homebrew-hackrf/blob/master/kalibrate-hackrf.rb - it is not in the main homebrew-core repo, so it has to be tapped:
also it uses https://github.com/rxseger/kalibrate-hackrf instead of https://github.com/scateu/kalibrate-hackrf primarily for https://github.com/scateu/kalibrate-hackrf/pull/8, but this could be changed.
And it doesn't fully follow the homebrew formula cookbook rules yet. The main blocker seems to kalibrate-hackrf would need a "stable release", e.g. a version tag, instead of only the git development 'master' branch:
would you be willing to make an official "release" of kalibrate-hackrf for this purpose?