scateu / kalibrate-hackrf

kalibrate for hackrf
BSD 2-Clause "Simplified" License
267 stars 78 forks source link

Homebrew formula for kalibrate-hackrf #10

Open rxseger opened 8 years ago

rxseger commented 8 years ago

Instead of https://github.com/scateu/kalibrate-hackrf/blob/master/INSTALL.homebrew manual instruction steps, why not submit a formula to homebrew-core so installation is simple as brew install kalibrate-hackrf?

I started one here: https://github.com/rxseger/homebrew-hackrf/blob/master/kalibrate-hackrf.rb - it is not in the main homebrew-core repo, so it has to be tapped:

brew tap rxseger/homebrew-hackrf
brew install kalibrate-hackrf

also it uses https://github.com/rxseger/kalibrate-hackrf instead of https://github.com/scateu/kalibrate-hackrf primarily for https://github.com/scateu/kalibrate-hackrf/pull/8, but this could be changed.

And it doesn't fully follow the homebrew formula cookbook rules yet. The main blocker seems to kalibrate-hackrf would need a "stable release", e.g. a version tag, instead of only the git development 'master' branch:

Stable versions Formulae in the core repository must have a stable version tagged by the upstream project. Tarballs are preferred to git checkouts, and tarballs should include the version in the filename whenever possible.

Software that only provides a development/beta, tagged version should be put in homebrew/devel-only. We don’t accept software without a tagged version because they regularly break due to upstream changes; we can’t provide bottles for them; and we don’t have an automatic update mechanism for head-only formulae which makes them very quickly outdated.

would you be willing to make an official "release" of kalibrate-hackrf for this purpose?

scateu commented 8 years ago

Hi Robert,

It's a great pleasure to see that this project works for you. But I am currently some kind of busy, and there is not enough time for me to submit a pull request for homebrew-core repo or do other kind of maintainance work.

I have added you as a collaborator of this project. You can push your changes directly into this repo, and do what you need to make this project more useful for other people.

Thanks.

Wang Kang

rxseger commented 8 years ago

Thanks scateu! I'll see what I can do.

rxseger commented 8 years ago

@scateu trying to push changes from my fork to here but I'm getting access denied, can you check:

kalibrate-hackrf $ git remote -v | grep origin
origin  git@github.com:scateu/kalibrate-hackrf (push)
origin  git@github.com:scateu/kalibrate-hackrf (fetch)
kalibrate-hackrf $ git push -u origin master
ERROR: Permission to scateu/kalibrate-hackrf.git denied to rxseger.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
scateu commented 8 years ago

Collaborators Push access to the repository

 @rxseger
 Robert X. Seger
 Awaiting rxseger's response

It seems that you have to confirm my invitation at some where.

rxseger commented 8 years ago

Got it, cheers! Pushed my changes

rxseger commented 8 years ago

Issues to resolve before publishing 1.0: