scateu / kalibrate-hackrf

kalibrate for hackrf
BSD 2-Clause "Simplified" License
267 stars 78 forks source link

c0_detect.cc:183:17: warning: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value] #11

Closed rxseger closed 8 years ago

rxseger commented 8 years ago

Getting this warning compiling with clang 7.3.0 on OS X 10.11.5: (should be a straightforward fix, but needs testing)

kalibrate-hackrf $ make
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-recursive
Making all in src
g++ -DHAVE_CONFIG_H -I. -I..    -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/hackrf/2015.07.2/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2 -MT kal-c0_detect.o -MD -MP -MF .deps/kal-c0_detect.Tpo -c -o kal-c0_detect.o `test -f 'c0_detect.cc' || echo './'`c0_detect.cc
c0_detect.cc:183:17: warning: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value]
      if (r && (fabsf (offset - GSM_RATE / 4) < ERROR_DETECT_OFFSET_MAX))
                ^
c0_detect.cc:183:17: note: use function 'std::abs' instead
      if (r && (fabsf (offset - GSM_RATE / 4) < ERROR_DETECT_OFFSET_MAX))
                ^~~~~
                std::abs
1 warning generated.
mv -f .deps/kal-c0_detect.Tpo .deps/kal-c0_detect.Po
g++ -DHAVE_CONFIG_H -I. -I..    -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/hackrf/2015.07.2/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2 -MT kal-kal.o -MD -MP -MF .deps/kal-kal.Tpo -c -o kal-kal.o `test -f 'kal.cc' || echo './'`kal.cc
mv -f .deps/kal-kal.Tpo .deps/kal-kal.Po
g++ -DHAVE_CONFIG_H -I. -I..    -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/hackrf/2015.07.2/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2 -MT kal-offset.o -MD -MP -MF .deps/kal-offset.Tpo -c -o kal-offset.o `test -f 'offset.cc' || echo './'`offset.cc
mv -f .deps/kal-offset.Tpo .deps/kal-offset.Po
g++ -DHAVE_CONFIG_H -I. -I..    -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/hackrf/2015.07.2/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2 -MT kal-usrp_source.o -MD -MP -MF .deps/kal-usrp_source.Tpo -c -o kal-usrp_source.o `test -f 'usrp_source.cc' || echo './'`usrp_source.cc
mv -f .deps/kal-usrp_source.Tpo .deps/kal-usrp_source.Po
g++ -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/hackrf/2015.07.2/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2   -o kal kal-arfcn_freq.o kal-c0_detect.o kal-circular_buffer.o kal-fcch_detector.o kal-kal.o kal-offset.o kal-usrp_source.o kal-util.o -L/usr/local/Cellar/fftw/3.3.4_1/lib -lfftw3 -L/usr/local/Cellar/hackrf/2015.07.2/lib -lhackrf 
kalibrate-hackrf $