search

sccn / lsl_archived

Multi-modal time-synched data transmission over local network
242 stars 134 forks source link

cmake links qt for msvc2017 when -G "Visual Studio 13 2015 [arch]" flag is given #330

Closed dmedine closed 6 years ago

dmedine commented 6 years ago

Maybe it does this for other values for -G as well. This doesn't seem to matter since the infrastructure is currently not copying the dlls into the installation directories (at least not on my setup) but this is definitely not desirable.

I get this at least with LiveAmp and LabRecorder.

cboulay commented 6 years ago

Did you get the warning that "You didn't specify a Qt5_DIR. I'm guessing it's ${Qt5_DIR}. If you are building Apps that require Qt and if this is wrong then please add the correct dir:"?

Here is the code in the super repo and this repo.

If you didn't get that warning then that means that Qt5_DIR is set.

And it absolutely should be copying the dlls, but only when you build the INSTALL target. Just building LabRecorder or LiveAmp itself won't trigger it. If you are building the INSTALL target but it still isn't copying the dlls, this might be because of the Qt weirdness; the dll copying is actually performed by a qt program.

dmedine commented 6 years ago

Your exactly right Chadwick. I was pointing to the wrong Qt version.

On 8/8/2018 3:39 PM, Chadwick Boulay wrote:

Did you get the warning that "You didn't specify a Qt5_DIR. I'm guessing it's ${Qt5_DIR}. If you are building Apps that require Qt and if this is wrong then please add the correct dir:"?

Here is the code in the super repo https://github.com/labstreaminglayer/liblsl/blob/master/LSLCMake.cmake#L212-L281 and this repo https://github.com/sccn/labstreaminglayer/blob/master/LSL/liblsl/LSLCMake.cmake#L219-L281.

If you didn't get that warning then that means that Qt5_DIR is set.

And it absolutely should be copying the dlls, but only when you build the INSTALL target. Just building LabRecorder or LiveAmp itself won't trigger it. If you are building the INSTALL target but it still isn't copying the dlls, this might be because of the Qt weirdness; the dll copying is actually performed by a qt program.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sccn/labstreaminglayer/issues/330#issuecomment-411408666, or mute the thread https://github.com/notifications/unsubscribe-auth/ADch7vr-mjDl1z9UtxzT8vE5Vi-lVxizks5uOuoWgaJpZM4Vz7Pp.