Name use case folder equal to use case in XML file

scenarioo / scenarioo-js

Scenarioo writer library to produce feature rich e2e test reports, e.g. from Protractor/WebDriverJS tests with Jasmine

http://www.scenarioo.org

MIT License

11 stars 4 forks source link

Name use case folder equal to use case in XML file #1

Closed adiherzog closed 10 years ago

adiherzog commented 10 years ago

If the use case name in the XML file has a space, this is represented as a plus sign (+) in the folder name. Looks as if the folder name is url encoded, but I'm not 100% sure.

bruderol commented 10 years ago

This is true folder and file names are URL encoded. This was done to ensure there is no problem with special characters.

xeronimus commented 10 years ago

what is the status here? what are the requirements? what should I change?

adiherzog commented 10 years ago

I'm not sure what the state is. I propose to do the following:

Write some unit tests that make sure folder names and file names are URL encoded.
Furthermore, the URL encoding should use + for spaces and not %20.
The use case folder name has to be the URL encoded version of the use case name in the usecase.xml file
The scenario folder name has to be the URL encoded version of the scenario name in the scenario.xml file.

I think most of this already works as it should. But it can't hurt to write some tests that make sure this is actually the case.

xeronimus commented 10 years ago

@adiherzog could you check the code/tests if this is now ok...

adiherzog commented 10 years ago

I'll review it as soon as I find some time for it.