tr7: overhaul - Githubissues

scheme-containers / monorepo

Generators, website, issues

https://containers.scheme.org

MIT License

7 stars 1 forks source link

tr7: overhaul #25

Closed lassik closed 2 months ago

lassik commented 2 months ago

Use symbolic links for scheme-banner and scheme-r7rs.
Use upstream make tr7i.
Omit ldconfig. It is not needed for most containers.
Omit TR7_LIB_PATH. The upstream head Makefile takes care of it.

The version 1 container currently does not install tr7libs. Upstream support for installation is underdeveloped in 1.0.14. It is easier to wait for the next 1.x release than to provide a workaround.

lassik commented 2 months ago

@Retropikzel I made a bunch of changes to tr7 in an effort to more closely follow our existing conventions as well as upstream conventions.

I built both containers and they seem to work as well as the old ones. Please check that I didn't make any obvious mistakes.

lassik commented 2 months ago

NB: make test currently fails due to upstream problems

Retropikzel commented 2 months ago

tr7 has "make install" support now https://gitlab.com/jobol/tr7/-/issues/38

There is no release out with it yet but it should work in the head.

lassik commented 2 months ago

The PR is using make install for head.

Retropikzel commented 2 months ago

Sorry, I should have looked more carefully. Then it's good for me.

lassik commented 2 months ago

No problem. Thank you for the swift review.