search

schettino72 / mergedict

mergedict - A Python `dict` with a merge() method
https://pypi.python.org/pypi/mergedict
Other
14 stars 1 forks source link

setup.py: Fix install_requires for Python >=3.4 #7

Closed hartwork closed 4 years ago

hartwork commented 4 years ago

The way that setup.py pulls singledispatch into install_requires…

https://github.com/schettino72/mergedict/blob/0069fcd5381d2299a50a5463a3f02565fbeef496/setup.py#L15-L17

… does not work for Python 3.4, as can be seen here:

# cd "$(mktemp -d)"

# virtualenv --python=python3.7 py37
[..]

# source py37/bin/activate
# pip install mergedict
Processing /home/user/.cache/pip/wheels/36/d4/87/7f9efc964baf0d177b4c477a4d19c52273e50aaec38e5952c8/mergedict-0.2.0-cp37-none-any.whl
Collecting singledispatch  <---
  Using cached singledispatch-3.4.0.3-py2.py3-none-any.whl (12 kB)
Collecting six
  Using cached six-1.14.0-py2.py3-none-any.whl (10 kB)
Installing collected packages: six, singledispatch, mergedict
Successfully installed mergedict-0.2.0 singledispatch-3.4.0.3 six-1.14.0

# python -c 'import mergedict, sys; print(sys.version_info[:2])'
(3, 7)

# pip freeze
mergedict==0.2.0
singledispatch==3.4.0.3  <--- should not be installed
six==1.14.0

This pull request provides a fix.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 75fe57ad8c243d27ea230e783b3d833f1f26c31a on setup-py-fix-install-requires-for-python-3-4 into 0069fcd5381d2299a50a5463a3f02565fbeef496 on master.