Lack of support for MaterialComponents

schibsted / account-sdk-android

⛔️ DEPRECATED Schibsted Account SDK for Android

https://schibsted.github.io/account-sdk-android/

MIT License

14 stars 8 forks source link

Lack of support for MaterialComponents #391

Open jkwiecien opened 5 years ago

jkwiecien commented 5 years ago

Environment

SDK Version: 1.7.0
Android Version: Any
Device Info: Any

Details

If the app inherits the theme from the MaterialComponents which is, for instance, Theme.MaterialComponents.Light.NoActionBar, the button brakes as the screenshot presents.

Workaround to this is setting AppCompat theme specifically to SDK activities like:

        <activity
            android:name="com.schibsted.account.ui.login.flow.password.PasswordActivity"
            android:theme="@style/Theme.AppCompat" />

Screenshot_20190612-100621

Nilzor commented 5 years ago

We have done the same workaround in Hermes. Do you have any idea how this could be fixed, @jkwiecien, without breaking Android 4x compatibility? (Not that 4x compatibility is something we care about in Hermes, but... )