search

schiehll / react-alert

alerts for React
MIT License
608 stars 98 forks source link

(fix) Peer dependencies issue related to React v18 #191

Open Blaumaus opened 2 years ago

Blaumaus commented 2 years ago

This PR fixed the issue occurring in some environments while installing this package.

22:53:01.146 | npm ERR! Could not resolve dependency:
22:53:01.146 | npm ERR! peer react@"^16.8.1 \|\| ^17" from react-alert@7.0.3
22:53:01.146 | npm ERR! node_modules/react-alert
22:53:01.146 | npm ERR!   react-alert@"^7.0.3" from the root project
ddkang commented 2 years ago

Any chance this could be merged?

DavidChouinard commented 2 years ago

@schiehll we're held up on this to upgrade our app, can we merge? 🙏

Blaumaus commented 2 years ago

@DavidChouinard until this PR is merged you can try out it's fork with the React 18 support - https://www.npmjs.com/package/@blaumaus/react-alert

DavidChouinard commented 2 years ago

Fantastic thank you. @schiehll would still be great to have this merged to have an official supported distribution

brightsider commented 2 years ago

@schiehll merge it pls

steeply commented 1 year ago

@schiehll when is the merge?

danielnathaniel commented 1 year ago

https://www.npmjs.com/package/@blaumaus/react-alert - this is not working and has the same issue as the original Node Package.

akamom commented 1 year ago

poke

oneil512 commented 10 months ago

Any reason this hasn't been merged yet?

dhwang commented 2 months ago

maybe @schiehll is no longer with us