Get version from git under source tree, regardless of build path

schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)

http://ccrm.vims.edu/schismweb/

Apache License 2.0

93 stars 88 forks source link

Get version from git under source tree, regardless of build path #132

Closed PhilMiller closed 7 months ago

PhilMiller commented 8 months ago

If a CMake build was configured in a path that wasn't a descendant of the source tree, gen_version.py would fail, because Git wouldn't be able to find its metadata. It should always run in the source tree, whether that build path is below that or not.

josephzhang8 commented 8 months ago

@water-e @kjnam : can u plz review this change? Thx @PhilMiller