Fix some initialisation issues

schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)

http://ccrm.vims.edu/schismweb/

Apache License 2.0

93 stars 88 forks source link

Fix some initialisation issues #17

Closed pryancsiro closed 4 years ago

pryancsiro commented 4 years ago

I've been working with Claire Trenham from CSIRO who suggested I submit these zero initialisation issues which we hunted down as the model we ran was giving non-reproducible results - these fixes seem to resolve that issue with at least one model configuration without the need for a compile flag.

josephzhang8 commented 4 years ago

Thank you so much Paul, Claire! We are reviewing your PR and will act soon...

Joseph

josephzhang8 commented 4 years ago

Hi Paul:

I've merged your PR and thx! I made some minor changes (.e.g. [uv]fg are no longer global) and you may want to review and test. Thank you and Claire again.