schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)
http://ccrm.vims.edu/schismweb/
Apache License 2.0
93 stars 88 forks source link

A bug for running pschism_COSINE using new io #66

Closed ZhenlinZhang closed 2 years ago

ZhenlinZhang commented 2 years ago

Running pschism_COSINE resulted in an error in: schism_step.F90, Line 9564: 'STEP: icount>nscribes(2.9)' And this error is caused by the following: in schism_ini.F90 Line 6767, do i=i,ntr(6), I think that it should be ntr(8), because ntr(6) corresponds to ECO.

josephzhang8 commented 2 years ago

Thx Zhenlin! I've pushed the fix.

-Joseph

Joseph Zhang Office: (804) 684 7466 Web: schism.wiki

From: ZhenlinZhang @.> Sent: Wednesday, May 4, 2022 8:44 PM To: schism-dev/schism @.> Cc: Subscribed @.***> Subject: [schism-dev/schism] A bug for running pschism_COSINE using new io (Issue #66)

[EXTERNAL to VIMS received message]

Running pschism_COSINE resulted in an error in: schism_step.F90, Line 9564: 'STEP: icount>nscribes(2.9)' And this error is caused by the following: in schism_ini.F90 Line 6767, do i=i,ntr(6), I think that it should be ntr(8), because ntr(6) corresponds to ECO.

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fissues%2F66&data=05%7C01%7Cyjzhang%40vims.edu%7Cdcc2c38743014d2c3b8608da2e305d45%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637873082494448136%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MT0RhUzKLEC%2Bogz5g1uPgOO%2B8gOvBOpT2Fx%2Fqi3NZ2M%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZYDLIIVVJOWOKP4U6TVIMKVPANCNFSM5VDTAJTQ&data=05%7C01%7Cyjzhang%40vims.edu%7Cdcc2c38743014d2c3b8608da2e305d45%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637873082494448136%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Yf5J0%2BEgkC%2BZ6%2FHf96OLc3%2FC6WYN1zAZBE%2FsIhBWaIY%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

jamal919 commented 2 years ago

Fixed in 98f3ad0add3db4258e04bb0cad6964c896e4a8f2