search

schollz / howmanypeoplearearound

Count the number of people around you :family_man_man_boy: by monitoring wifi signals :satellite:
MIT License
6.92k stars 386 forks source link

Create a Docker image #47

Open aditisrinivas97 opened 5 years ago

aditisrinivas97 commented 5 years ago

Create a docker image with all dependencies installed.

schollz commented 5 years ago

Different than https://github.com/schollz/howmanypeoplearearound/blob/master/README.md#docker-alternative ?

aditisrinivas97 commented 5 years ago

What is present here is just a Dockerfile which means every time someone builds, it will have to install everything. My suggestion was to build an image and push it to DockerHub where everyone can just pull the image having all the dependencies installed.

schollz commented 5 years ago

Sounds good. I'm not the one to do this though because I don't have Mac OS.

aditisrinivas97 commented 5 years ago

Hey, on second thoughts, all you need to do is publish the built image on Dockerhub. I can do it but if I do, I'll be the owner of the image. If you want me to do it, I can publish it and update the README. Let me know what works for you.

kevholmes commented 3 years ago

@schollz Hey - I just saw this issue and was thinking it could be implemented using a GitHub container repo combined with GitHub Actions. I could write an action that runs when you cut a release in GitHub with a semver. We could build the docker image in an Actions runner and push it out to the GitHub container repo with a tagged version. Then the public at large could pull from the ghcr.io repo if they're looking to use a container image, without having to deal with the build portion. LMK and I could get started on it.