search

schubmat / Custom-MADE

Custom-MAnangement of DEcision -- A DSL based approach to capture and manage your decisions during a software development project
MIT License
5 stars 3 forks source link

Fix Inversify Error in Theia Diagram Extension #33

Closed rrcomtech closed 3 years ago

rrcomtech commented 3 years ago

An error occurs when trying to run an updated version of Theia. The error is already known and described in the Sprotty main repository https://github.com/eclipse/sprotty/issues/201.

Full console log: https://pastebin.com/0KF4vjDm

Possible Solution: Update to Sprotty 0.10.0

schubmat commented 3 years ago

Updated sprotty in b0e45484b254260fbf7315fede11aa4baa124905

see /schubmat/Custom-MADE/tree/feature-integrate-visual-editing

However, some compile errors remain. As soon as I have more time, I could have a loot at it. May be @rrcomtech or @pcprinz could have a look at it before that?

rrcomtech commented 3 years ago

First error messages showing the error 

error TS2322: Type 'Element' is not assignable to type 'VNode'.

eliminated by f2dd1036cb4fe8875e28991aa2d5c039a6d833e4 (see here). New errors remaining.

rrcomtech commented 3 years ago

The error stated that modules are not present anymore in Sprotty-Theia 0.10.0. It looked like this (for multiple modules):

src/browser/diagram/diagram-configuration.ts(3,10): error TS2305: Module '"sprotty-theia"' has no exported member 'CodeActionPalettePopupProvider'.

It was done, because many LSP-related modules were moved to eclipse/sprotty-vscode. This topic is discussed in these issues:

To put it short: Theia does not support LSP-related modules anymore. The new approach is to implement a VSCode extension, which still does support LSP-related modules.

An example for a reimplementation of a VSCode Sprotty extension is given in eclipse/sprotty-vscode. The reimplementation should be the new main focus, which resolves this issue.

rrcomtech commented 3 years ago

Fixed by 10d62d2af2a5e48b41574ca038dbeb05d9b726f1.