search

scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Action buttons missing from works when logged in #179

Closed KatharineV closed 4 months ago

KatharineV commented 5 months ago

After the Knapsack upgrade, action buttons are missing from works on production. The buttons we expect to see are Edit, Delete, Attach Child, Add to Collection, and Feature. See screenshots below for an example of ADL staging (with buttons) compared to ADL and SDAPI prod (no buttons).

Staging with buttons:

https://adl.s2.adventistdigitallibrary.org/concern/images/p005873_clinton_theological_seminary_sextelles_1921?locale=en Image

Prod without buttons:

https://adl.b2.adventistdigitallibrary.org/concern/published_works/22266468_cardinal_1986 Image

https://sdapi.b2.adventistdigitallibrary.org/concern/journal_articles/davarlogos_2023_2_59_93_the_compatibility_of_christ_s_ascension_in_the_epis?locale=en Image

ShanaLMoore commented 5 months ago

Pass: ✅

STAGING

Image

KatharineV commented 5 months ago

Confirmed that action items are showing on ADL and SDAPI production and staging when I am logged in. Screenshots below are just production. Note that we're seeing the "Public" tag, which wasn't present before. At some point that was masked in our instance of Hyku. Not sure when it came back, but it seems like Knapsack revealed it, since the pre-Knapsack staging screenshot at the top of the ticket doesn't include the Public visibility tag.

Note also that the location and look of the action buttons has changed. That's inconsequential and I don't want the team to waste time moving the buttons, but I would like to see the Public visibility tag go away, at least for visitors who are not logged in. When viewing works while logged out, there's no point to the visibility tag. If you can see it, it's public, so the tag is clutter. Can it go away? Does this need its own ticket, or is it related to the other buttons at the top of a work?

ADL Image

SDAPI Image

ShanaLMoore commented 5 months ago

@KatharineV I'm going to create a new ticket for the public tag issue. If you are ok with the buttons as they are, please consider re verifying. Otherwise we can also make a ticket to change their position.

KatharineV commented 5 months ago

Thanks, @ShanaLMoore . I'll move this ticket to done, since the buttons are present and they work. I really don't think the button location matters at all, as long as they're close to where people will look for them, and they work.