karanphil commented 2 months ago

Quick description

This is a small PR to add the option of not normalizing the density maps. For instance, if you want to keep the information about the streamline count or the sift2 weight, you can now use --norm none. You can also use multiple choices like --norm voxel none and it will produce outputs for both.

The for loop on the norm options makes it look like all the code has changed in the script, but it is basically the same as before inside the loop, with shorter variable names to respect pep8.

Type of change

Enhancement

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[ ] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

pep8speaks commented 2 months ago

Hello @karanphil, Thank you for updating !

In the file scripts/tests/test_bundle_fixel_analysis.py:

Line 79:1: W293 blank line contains whitespace

Comment last updated at 2024-11-08 19:31:24 UTC

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.94%. Comparing base (4bde487) to head (754cc96). Report is 19 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1032 +/- ## ========================================== + Coverage 68.88% 68.94% +0.05% ========================================== Files 434 434 Lines 22643 22657 +14 Branches 3077 3080 +3 ========================================== + Hits 15598 15621 +23 + Misses 5728 5724 -4 + Partials 1317 1312 -5 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1032/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1032/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.68% <100.00%> (+0.09%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1032/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.91% <100.00%> (+0.01%)` | :arrow_up: |

scilus / scilpy