scipp / essnmx

Data reduction for NMX at the European Spallation Source
https://scipp.github.io/essnmx/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Average scaled intensities scaled by estimated scale factors. #59

Closed YooSunYoung closed 5 months ago

YooSunYoung commented 6 months ago

Continued from #58

I'm opening a new one since the base branch was updated a lot and there were too many conflicts to resolve...

The result of the scaling workflow now is, the data points to fit the real scaling function with.

YooSunYoung commented 6 months ago

There was one more request that allows swapping filtering function easily, (cutting out tails of the data points mostly) to compare different filtering functions. I'll reopen it after fixing that.

YooSunYoung commented 5 months ago

@Justin-Bergmann and @aaronfinke briefly have reviewed in person with me. It'll be nice if you can review them here as well. Especially the documentation part.

You can download the built-documentation page here: https://github.com/scipp/essnmx/actions/runs/9075813196?pr=59 There is a download button next to docs_html under Artifacts section.

jokasimr commented 5 months ago

We should have a chat where you explain how this works, that would make it easier for me to review :)