search

scipp / essreduce

Common functionality for ESS data reduction
https://scipp.github.io/essreduce/
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Load histogram data #106

Closed jl-wynen closed 2 months ago

jl-wynen commented 2 months ago

Alternative to #104. This PR makes it so that the nexus workflow can automatically load histogram data if a file contains that instead of events.

SimonHeybrock commented 2 months ago

Have you tested if this still passes all the ESSsans and ESSdiffraction tests/builds?

jl-wynen commented 2 months ago

No. I was not aware that those count as tests for ESSreduce. I can do this now. But we very much should implement #103

SimonHeybrock commented 2 months ago

No. I was not aware that those count as tests for ESSreduce. I can do this now. But we very much should implement #103

These are not using LoadNexusWorkflow, but GenericNexusWorkflow. There are tests in https://github.com/scipp/essreduce/blob/main/tests/nexus/workflow_test.py and https://github.com/scipp/essreduce/blob/main/tests/nexus/generic_workflow_test.py, but as this is a rather complex piece I'd still prefer to run those downstream checks.

jl-wynen commented 2 months ago

Those tests don't test the workflows, only individual providers.

SimonHeybrock commented 2 months ago

They do? https://github.com/scipp/essreduce/blob/aef4a3c1094dd15f1849aedc74e9960e1b922de3/tests/nexus/generic_workflow_test.py#L36-L51

jl-wynen commented 2 months ago

All tests and docs in essdiffraction and esssans pass.