scipp / essreduce

Common functionality for ESS data reduction
https://scipp.github.io/essreduce/
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Fix signal finding in Nexus group tripping up on time-dependent transform #95

Closed SimonHeybrock closed 1 month ago

jokasimr commented 1 month ago

Might there be other names we want to ignore? Is there a way we can figure out what they are or should we just wait and see until we encounter them?

SimonHeybrock commented 1 month ago

Might there be other names we want to ignore? Is there a way we can figure out what they are or should we just wait and see until we encounter them?

Hard to say. These two are added by ScippNexus. If someone put, e.g., NXlog in the NXdetector it will break again, but then it is actually not a false positive.